Issue 132 - Setup DataModel As Context Manager For Reader Cleanup.#133
Draft
gauppj1 wants to merge 1 commit intovandeplaslab:mainfrom
Draft
Issue 132 - Setup DataModel As Context Manager For Reader Cleanup.#133gauppj1 wants to merge 1 commit intovandeplaslab:mainfrom
gauppj1 wants to merge 1 commit intovandeplaslab:mainfrom
Conversation
gauppj1
commented
Feb 3, 2026
| """Close resources.""" | ||
| self.close() | ||
|
|
||
| def __enter__(self) -> None: |
Author
There was a problem hiding this comment.
Todo - I know there's a typing approach that allows the class' type to be referenced within the class. Futures?
Minor - del and exit do double duty, could check for closed. exit returns bool or none?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.