Fix AttributeError in benchmark_expression_conversion Method#6
Open
ayyucedemirbas wants to merge 2 commits into
Open
Fix AttributeError in benchmark_expression_conversion Method#6ayyucedemirbas wants to merge 2 commits into
ayyucedemirbas wants to merge 2 commits into
Conversation
This pull request addresses an AttributeError encountered in the benchmark_expression_conversion method of the utils.py module in the cell2sentence repository. The error occurred when attempting to access the .item() method on values that are of type float, which does not have this method. Modified the lines in the benchmark_expression_conversion method to handle float values correctly. Removed the .item() method call on the r_squared_score, pearson_r_score, and spearman_r_score metrics since they return floats directly.
Adding LoRA Fine-Tuning
Author
|
Added LoRA fine-tuning using peft. However, I'm not able to try it, because, since I'm working on Google Colab, CUDA memory is not enough to fine-tune the model. Could you please try it for me? @SyedA5688 Thank you so much! |
|
We are not able to try this for you.
…On Mon, Oct 14, 2024 at 17:37 Ayyuce Demirbas ***@***.***> wrote:
Added LoRA fine-tuning using peft. However, I'm not able to try it,
because, since I'm working on Google Colab, CUDA memory is not enough to
fine-tune the model. Could you please try it for me? @SyedA5688
<https://github.com/SyedA5688> Thank you so much!
—
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAR7M43OGIKJL2GEDQAHFTZ3Q2TDAVCNFSM6AAAAABP2VZJWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJSGM4DGOBXGY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
AttributeError: 'float' object has no attribute 'item' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses an AttributeError encountered in the benchmark_expression_conversion method of the utils.py module in the cell2sentence repository. The error occurred when attempting to access the .item() method on values that are of type float, which does not have this method.
Modified the lines in the benchmark_expression_conversion method to handle float values correctly. Removed the .item() method call on the r_squared_score, pearson_r_score, and spearman_r_score metrics since they return floats directly.