fix build#180
Conversation
WalkthroughThe changes update the GitHub Actions release workflow to ensure all matrix jobs run to completion by setting Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Note 🔌 MCP (Model Context Protocol) integration is now available in Early Access!Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
.github/workflows/release.yml(1 hunks)package.json(2 hunks)
🔇 Additional comments (2)
package.json (1)
6-6: Version bump looks good.0.8.2 aligns with a patch release; no issues spotted here.
.github/workflows/release.yml (1)
14-14: Correct: fail-fast disabled for full matrix visibility.This ensures macOS, Windows, and Linux jobs all complete even if one fails. Good for diagnosing platform-specific issues.
| "optionalDependencies": { | ||
| "dmg-license": "^1.0.11" | ||
| } |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Optional mac-only tooling: good call; verify it’s actually used.
Adding dmg-license as an optional dependency should prevent non-mac builds from breaking. Ensure your electron-builder config specifies a DMG license; otherwise this package won’t be exercised on mac builds.
Run to check if a DMG license is configured:
Optionally consider pinning dmg-license to an exact version to reduce CI variance, unless you rely on upstream patch updates.
🏁 Script executed:
#!/bin/bash
# Look for electron-builder DMG license config in package.json or any config files.
rg -n '"dmg"\s*:\s*{[^}]*"license"' -A3 -U package.json || true
rg -n '"mac"\s*:\s*{[^}]*"dmg"' -A10 -U package.json || true
rg -n '"license"\s*:\s*".*\.rtf"|".*\.txt"' -ULength of output: 417
🏁 Script executed:
#!/bin/bash
# 1. Check for a DMG license entry in package.json’s build section
jq -r '.build?.mac?.dmg?.license // empty' package.json | sed '/^$/d'
# 2. Search for any .rtf or .txt references in JSON/YAML config files
rg -n '\.rtf' -g '*.json' -g '*.yml' -g '*.yaml' || true
rg -n '\.txt' -g '*.json' -g '*.yml' -g '*.yaml' || true
# 3. Locate electron-builder YAML/JSON config files and look for a "dmg:" block
fd -e yml -e yaml -e json . -x rg -n '"dmg"\s*:' -A3 {} || trueLength of output: 254
🏁 Script executed:
#!/bin/bash
# Search for electron-builder config in JS/TS files for a DMG license entry
# 1. Look for any build.mac.dmg.license references in JS/TS
rg -n 'build\?\.[ ]*mac\?\.[ ]*dmg\?\.[ ]*license' -g '*.ts' -g '*.js' -A3 || true
# 2. Look for any 'dmg' blocks in JS/TS builder configs
rg -n 'mac\?\.[ ]*dmg' -g '*.ts' -g '*.js' -A5 || true
# 3. Look for explicit license file paths (rtf/txt) in JS/TS
rg -n '\.rtf' -g '*.ts' -g '*.js' || true
rg -n '\.txt' -g '*.ts' -g '*.js' || trueLength of output: 7944
Ensure a DMG license is configured for mac builds
It looks like there’s no build.mac.dmg.license entry in your Electron-Builder configuration, so the dmg-license package won’t actually be used on macOS. Please add a reference to your license file (RTF or TXT) under the build.mac.dmg.license key. Also consider pinning the dmg-license version to avoid unexpected CI updates.
– package.json
• Under the build section, add:
json "build": { "mac": { "dmg": { "license": "path/to/your-license.rtf" } } }
– package.json (optionalDependencies)
• Pin to an exact version for stability:
"dmg-license": "1.0.11"
🤖 Prompt for AI Agents
In package.json around lines 141 to 143, the Electron-Builder config lacks a
build.mac.dmg.license entry, so the dmg-license package is unused on macOS. Add
a "build" section if missing, then under "mac" add "dmg" with a "license" key
pointing to your license file path (RTF or TXT). Also, change the
optionalDependencies entry for dmg-license to pin the version exactly as
"1.0.11" instead of using a caret range to ensure stable CI builds.
1 participant
Summary by CodeRabbit