[codex] Tighten Clippy lint policy#98
Merged
Merged
Conversation
|
Important Review skippedToo many files! This PR contains 300 files, which is 150 over the limit of 150. To get a review, narrow the scope: ⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (300)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary
This PR successfully implements a comprehensive Clippy lint policy upgrade across the workspace, adding clippy::pedantic and carefully selected clippy::restriction lints. The changes are extensive (535 files) but mostly mechanical, focused on addressing lint warnings through:
- Adding workspace-level lint configuration in
Cargo.toml - Using
saturating_add/saturating_subfor arithmetic operations to prevent overflows - Adding
#[must_use]attributes to constructors - Adding
#[expect(...)]suppressions with clear justification - Reordering struct fields and enum variants for consistency
Critical Issue Found
1 blocking issue identified that could cause crashes in production:
The current_timestamp() function in crates/rginx-agent/src/circuit_breaker.rs uses unwrap() on SystemTime::now().duration_since(UNIX_EPOCH), which will panic if the system clock is set before the Unix epoch. This needs to be replaced with expect() and a descriptive message, or proper error handling.
Validation
The PR description indicates thorough testing with multiple Clippy configurations and standard test/build commands, which demonstrates proper validation of the changes.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces extensive code reorganization, linting improvements, and safety enhancements across the workspace. Key changes include the adoption of stricter Clippy lints, field and method reordering for consistency, and the use of saturating arithmetic and interpolated strings. Feedback suggests extending the use of the #[must_use] attribute to all side-effect-free methods and replacing panicking calls like expect() with fallible parsing when handling potentially untrusted input to improve robustness.
vansour
force-pushed
the
codex/clippy-strict-lints
branch
from
9da8233 to
6eeb0d8
Compare
vansour
force-pushed
the
codex/clippy-strict-lints
branch
from
6eeb0d8 to
36b53f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clippy::pedanticand selected high-signalclippy::restrictionlints[lints] workspace = trueValidation
cargo clippy --workspace --all-targets --all-features --locked -- -D warningscargo clippy --workspace --all-targets --all-features --locked -- -D warnings -W clippy::restrictioncargo clippy --workspace --all-targets --all-features --locked -- -W clippy::restriction./scripts/run-clippy-gate.shcargo check --workspace --all-features --lockedcargo test --workspace --all-features --locked --libcargo fmt --all --checkgit diff --check