Conversation
MahdiBM
reviewed
Mar 10, 2026
.github/workflows/run-unit-tests.yml
Outdated
| run: | | ||
| git config --global --add safe.directory "${GITHUB_WORKSPACE}" | ||
| swift package ${PACKAGE_ROOT} diagnose-api-breaking-changes --baseline-dir=${BASELINES} --regenerate-baseline origin/main | ||
| - { name: Cache API baseline, uses: actions/cache/save@v5, with: { path: "${{ env.BASELINES }}", key: api-breakage } } |
Contributor
There was a problem hiding this comment.
With this key, what happens is that in the first run the "restore" step doesn't have anything to restore, but the "cache" step will cache the build.
Then in the second run the "restore" step will work, but then the "cache" step never does anything because the cache key is always the same and so the action says "this cache already exists". It doesn't replace or update the old cache.
So we probably would want to have some kind of hash in front of the key.
MahdiBM
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just for you, @MahdiBM 😘