docs(adr): renumber chat-message-store ADR to 0020 to resolve collision#118
Merged
Merged
Conversation
Commit 4a28f57 renumbered the original 0011-coordinator-boundary.md to 0018-coordinator-boundary.md on main, but PR #114 (merged after that) introduced 0018-chat-message-store.md without rebasing against the new numbering, creating a fresh duplicate at slot 0018. Rename the chat-message-store ADR (lower-churn side of the collision — 0018-coordinator-boundary is referenced from 0015 and 0019, while 0018-chat-message-store has no external in-repo references) to the next free slot 0020. Update the title and the six in-body references to "ADR-0011" — which were already stale after the 4a28f57 renumber — to point at the correct "ADR-0018". decisions/ now has unique four-digit prefixes across all files.
Owner
Author
Code reviewNo issues found. Checked for missed stale references, duplicate prefixes, and CLAUDE.md compliance. One finding from the review agent (claim that `0019-roadflared-url-scheme.md:107` mis-attributes "AppState as single facade for view data") was verified as a false positive: the reference targets the concept's source (the coordinator-boundary refactor, now ADR-0018) — `0011-presentation-projection-layer.md` itself attributes the phrase to "the coordinator-boundary refactor (ADR-0001, PR #58)", so the verbatim phrase living in 0011 is a quotation of the 0018 concept, not its definition. 🤖 Generated with Claude Code |
3 tasks
Owner
Author
Code review (full ritual)No issues found. 5-agent pass:
🤖 Generated with Claude Code |
3 tasks
variablefate
added a commit
that referenced
this pull request
May 12, 2026
…AppendOutcome (#121) The .inserted associated value was added to support a haptic-decision use case that turned out not to need it. ChatCoordinator.handleChatEvent only ever pattern-matches on `case .inserted` for the haptic — it never reads the payload. Tests that exercised the unread side effect also assert store.unreadCount directly (the canonical source). Drop the payload. The enum becomes: case duplicate case inserted Updated ADR-0020 rationale + alternatives. (Re-opens the auto-closed PR #119; rebased onto main after PR #118 merged.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the duplicate-numbering at decisions/0018-* introduced when PR #114 (ChatMessageStore extraction) landed without rebasing against commit 4a28f57 — that commit renumbered the original 0011-coordinator-boundary.md to 0018-coordinator-boundary.md, and PR #114 picked 0018 for chat-message-store independently.
Why this side of the collision
Lower churn:
Test plan
Related: #114 (introduced the collision); commit 4a28f57 on main (did the prior 0011/0012 renumber).