feat: support for ANSI color sequences(#338)#655
feat: support for ANSI color sequences(#338)#655nowhszh wants to merge 2 commits intovariar:masterfrom
Conversation
|
Currently it's only to show what it looks like after parsing, and it will still take some time before it's merged. Here is the final plan:
|
|
That's a good start! Moving all escape handling to a separate class should make it easier to reuse. In current implementation escape sequences are dropped when reading lines from file. That way searching never sees them. If they are passed to UI and then transformed into actual colors, then they have to be dropped before the line is passed to hyperscan. One idea to think about -- drop the escape sequences at the same place they are dropped now and construct a set of highlighters that should be applied to that line, could be in raw lines struct. This way there is no need to change search and quickfind code. And AbstractLogView change would be to add any such highlighters to the set. |
Thank you very much, I will think about this and give reasons for my final choice! |
|
@variar
If you think this approach is OK, I will implement it more completely and apply it in the current PR |
0ee2f44 to
cce45e6
Compare
|
Development is basically complete. |
@nowhszh Can you please show a screenshot of the effect after integration into |
I can't record on my computer. I'll record on a different computer tomorrow. |
Functionality is available in the current commit code, but some code needs to be optimized before the merge is complete |
1ea2633 to
8ad7bea
Compare

Image 1:


Image 2: