Conversation
Signed-off-by: Elazar Gershuni <elazarg@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 764db9d73f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| public: | ||
| using Graph = splitdbm::AdaptGraph; | ||
| using VertMap = boost::container::flat_map<Variable, splitdbm::VertId>; | ||
| using VertMap = std::flat_map<Variable, splitdbm::VertId>; |
There was a problem hiding this comment.
Switching ZoneDomain::VertMap to std::flat_map makes this TU require the C++23 <flat_map> header, which is not available in common supported environments (e.g., GCC/libstdc++ 13 on Ubuntu 24.04, where #include <flat_map> fails). Because our CI workflow installs the default g++ via apt in .github/workflows/build.yml (Build job), this change can break builds for contributors and CI until the minimum compiler/libstdc++ baseline is raised or guarded.
Useful? React with 👍 / 👎.
|
Apparently ubuntu-latest is not ready for this |
1 participant
No description provided.