Skip to content

Norebo#768

Open
22Chaos wants to merge 4 commits intovck3000:masterfrom
22Chaos:norebo
Open

Norebo#768
22Chaos wants to merge 4 commits intovck3000:masterfrom
22Chaos:norebo

Conversation

@22Chaos
Copy link
Copy Markdown

@22Chaos 22Chaos commented Mar 4, 2026

Adds Norebo. A random resistance member that appears as a spy to fellow spies.

22Chaos added 4 commits March 4, 2026 15:14
…ies.

Implemented as a card, not a role.
Currently, only the Assassin can see Norebo.
Not saved in database records.
Not yet announced at the end of the game.
Moregano sees an additional dummy-spy if norebo is in game.
Copy link
Copy Markdown
Owner

@vck3000 vck3000 Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come you decided to implement it as a card?
A card is intended to be passed around, and is public to the players, meaning everyone will know who norebo is?

If you implement it as a card, we also lose nice game record data collection, user stats, etc.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come you decided to implement it as a card?

Because the card infrastructure that is already implemented makes for a more reliable way to "modify" roles. The alternative would be to store some kind of norebo variable in the Game object. Or having to create a norebo variable for every res role, or worse, create roles like "NoreboPercy" and "NoreboMerlin." Making cards more general and treating them like "player-modifiers" makes the implementation cleaner and more applicable, especially if someone wants to add Palm, or Arthur (a common res that everyone knows).

A card is intended to be passed around

This one cannot be passed around.

and is public to the players,

Not this one. At least, I don't think this data is available in public game data.

If you implement it as a card, we also lose nice game record data collection, user stats, etc.

Do we? The database tracks who held the Norebo card. So everything should be recoverable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants