Refactor dialog disposition handling to accept any string value#35
Open
pavanputhra wants to merge 1 commit intomainfrom
Open
Refactor dialog disposition handling to accept any string value#35pavanputhra wants to merge 1 commit intomainfrom
pavanputhra wants to merge 1 commit intomainfrom
Conversation
Contributor
pavanputhra
commented
Feb 27, 2026
pavanputhra
commented
- Updated DialogSchema and Dialog interface to allow any string for disposition, enhancing flexibility.
- Adjusted validation logic to ensure any string is accepted for incomplete dialog dispositions.
- Added migration to drop the CHECK constraint on dialog disposition in the database.
- Updated tests to validate acceptance of both spec-suggested and custom disposition values.
- Updated DialogSchema and Dialog interface to allow any string for disposition, enhancing flexibility. - Adjusted validation logic to ensure any string is accepted for incomplete dialog dispositions. - Added migration to drop the CHECK constraint on dialog disposition in the database. - Updated tests to validate acceptance of both spec-suggested and custom disposition values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.