fix: poll for search-index visibility in three flaky query tests

[goharanwar]

Summary

Three tests have been failing intermittently on staging:

• tests/services/corpus/test_filter_attributes_types.py::TestFilterAttributeTypes::test_text_integer_boolean_filters
• tests/services/indexing/test_document_lifecycle.py::TestDocumentLifecycle::test_index_query_delete_query_cycle
• tests/services/query/test_query_filters.py::TestQueryFiltersCore::test_query_with_valid_metadata_filter

All three failed the same way: AssertionError: assert 0 > 0 on a len(search_results) > 0 check immediately after indexing.

Root cause

Each test uses this pattern after indexing:

wait_for(lambda: client.get_document(corpus_key, doc_id).success, ...)
query_resp = client.post("/v2/query", ...)
assert len(query_resp.data["search_results"]) > 0  # flaky

get_document returning 200 only confirms the document is stored — not that it is searchable. There is an eventual-consistency window between document storage and search-index visibility. When that window is longer than usual on staging, the first /v2/query returns zero results and the test fails. The product is behaving correctly; the synchronization signal is wrong.

test_document_lifecycle.py already has the right pattern on the delete side (_krakatoa_gone polled via wait_for), but the index-and-query side did not.

Fix

Replace each immediate post-index query + assertion with a wait_for(...) poll that retries the query until it returns results (timeout 30s, interval 2s). All other content assertions (correct doc, correct fields, correct filtering) are preserved.

Test plan

• Reproduced behaviour: original tests passed when run in isolation but the failure mode (get_document ≠ searchable) is well understood from the test code and direct curl reproduction.
• Ran the three patched tests against staging (https://api.vectara.dev): 3 consecutive runs × 3 tests = 9/9 PASS.
• Ran all 5 tests in the three modified test modules (incl. error-path tests): 5/5 PASS.
• No production code changes — fix is contained to the api_test_suite tests.

🤖 Generated with Claude Code

[goharanwar]

Closing in favour of #8, which now contains both the search-index visibility fix and the retry-policy/observability fix. Combined branch tested end-to-end on staging: 12/12 originally-failing tests pass, plus 87/87 on the broader core profile across agents/corpus/indexing/query services.