fix(topology): prevent security_confinement_disabled gauge from expiring#25910
Open
thomasqueirozb wants to merge 1 commit into
Open
fix(topology): prevent security_confinement_disabled gauge from expiring#25910thomasqueirozb wants to merge 1 commit into
thomasqueirozb wants to merge 1 commit into
Conversation
github-actions
Bot
added
domain: topology
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
thomasqueirozb
marked this pull request as ready for review
July 21, 2026 16:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
vector_security_confinement_disabledgauge was emitted once per sink at build time and its handle dropped immediately, so the metric aged out of the registry after the idle timeout (300s by default) while the sink was still running with confinement disabled. Ownership of the gauge is moved to the topology, which holds a handle for each confinement-aware sink's lifetime and reconciles the gauges on every (re)load.Vector configuration
NA
How did you test this PR?
make check-clippy,make check-fmt, andmake check-changelog-fragmentsall pass. Addedsrc/topology/test/confinement_gauge.rscovering per-sink series at startup, absence for non-confinement sinks, and value updates on reload; the topology test suite passes (cargo nextest run --lib topology::test::).Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
NA