chore(value): migrate Arbitrary impls from quicktest to proptest#1864
Draft
hjooh wants to merge 2 commits into
Draft
chore(value): migrate Arbitrary impls from quicktest to proptest#1864hjooh wants to merge 2 commits into
hjooh wants to merge 2 commits into
Conversation
Scope: value crate (and minorly, path crate). Replaces the quickcheck Arbitrary impls for Value, BorrowedSegment, and KeyString with proptest strategies to eliminate a duplicate dependency on rand (quickcheck uses v0.8 and proptest uses v0.9). quickcheck::Arbitrary impl has been removed from arbitrary.rs, and the quickcheck property test has also been replaced.
hjooh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WIP - Vector side PR needs to be pushed
Change Type
Is this a breaking change?
How did you test this PR?
Does this PR include user facing changes?
our guidelines.
Checklist
run
dd-rust-license-tool writeand commit the changes. More details here.References