Drhuffman12/upgrade to crystal 1.1.1#1
Closed
drhuffman12 wants to merge 7 commits intovectorselector:masterfrom
Closed
Drhuffman12/upgrade to crystal 1.1.1#1drhuffman12 wants to merge 7 commits intovectorselector:masterfrom
drhuffman12 wants to merge 7 commits intovectorselector:masterfrom
Conversation
…rystal-lang/crystal#9527); (Refactor to use JSON::Serializable instead?)
…add more db conn env var's
…ndor#version" not getting parsed in?
…'2.x.x'). (TODO: Add applicable tests for '3.x.x' changes.); TODO: Why "CouchDB::Response::Vendor#version" not getting parsed in?
…omment out Crystal version requirement (note compatibility elsewhere?)
Author
|
Closing; replace by #2 . |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-[x] Add dependency of
crystal-lang/json_mapping.cr/ (JSON.mappingwas deprecated and moved to shard.)-[x] Add more environment variables for database connection settings with defaults.
-[x] DEPRECATION: Use
ServerInfo#versioninstead ofVendor#version.As of v3.x (or earlier?), a call to the server's root (e.g.:
GET http://127.0.0.1:5984/)no longer returns
versioninsidevendor.In v3.x, response will instead look like:
-[x] Allow
3.x.xversions of CouchDB.is_v2?andis_v3?methods toCouchDB::Response::ServerInfo.-[x] Remove hard-coded
crystalkey/version fromshard.yml(for now).-[x] Bump version of this shard to
0.4.0CouchDB::VERSIONbased on shard version value in fromshard.yml(to avoid out-of-sync issues).