Merged
Conversation
Decouple secrets manager from core functionality so users can run ComposeFlux without configuring a secrets provider. - Consolidate 3 secrets fields in CommonConfig into single embedded secrets.Config - Make secrets provider optional (enum allows empty, default "") - Return nil client from secrets.New() when no provider configured - Add nil guard in cacheLoadSecrets() and before sClient.Get() - Change DeployKeySecretRef default from "SSH_PRIVATE_KEY" to "" (opt-in) - Update documentation to reflect optional secrets provider - Add .prettierrc.yaml for markdown formatting Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Closed
1 task
There was a problem hiding this comment.
Pull request overview
This PR decouples secrets management from core operation so ComposeFlux can run without a configured secrets provider, while consolidating secrets-related CLI/config fields into a single secrets.Config and updating docs accordingly.
Changes:
- Make secrets provider optional (secrets client can be
nilwhen unconfigured) and guard secrets-loading paths. - Consolidate secrets configuration into
secrets.Configand update CLI validation/initialization logic. - Switch
GIT_DEPLOY_KEY_SECRET_REFdefault to empty (opt-in) and refresh documentation + formatting/tooling.
Reviewed changes
Copilot reviewed 17 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates feature bullets/formatting to describe secrets as optional. |
| pkg/source/git.go | Makes deploy key secret ref opt-in by defaulting to empty. |
| pkg/secrets/client.go | Introduces optional Provider in secrets config and updates client factory behavior. |
| pkg/secrets/bitwarden.go | Minor formatting/alignment in config struct fields. |
| internal/reconcile/run.go | Simplifies startup log line. |
| internal/reconcile/reconcile.go | Flattens reconciler config by removing nested Timers struct. |
| internal/reconcile/cache.go | Skips secrets fetch when no secrets client is configured. |
| go.sum | Dependency checksum updates due to module bumps. |
| go.mod | Adjusts Go version directive and bumps several dependencies. |
| docs/Introduction.md | Updates narrative/formatting and removes “secrets required” implication. |
| docs/index.md | Updates summary bullets to describe secrets as optional. |
| docs/how-to-guides/Infisical.md | Reflows text and clarifies deploy-key guidance. |
| docs/how-to-guides/GithubDeployKeys.md | Updates guidance for opt-in deploy key fetching and provider requirement. |
| docs/how-to-guides/Bitwarden.md | Reflows text and clarifies deploy-key guidance. |
| docs/GettingStarted.md | Marks secrets provider as optional; updates env var tables and examples. |
| docs/Development.md | Reflows documentation about CGO/Bitwarden SDK requirements. |
| cmd/composeflux/common.go | Embeds secrets.Config, updates validation, and makes secrets client optional with nil-safe cleanup. |
| AGENTS.md | Updates documentation to describe secrets as optional and bumps stated Go version. |
| .prettierrc.yaml | Adds Prettier configuration for consistent prose wrapping. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CommonConfiginto a single embeddedsecrets.ConfigGIT_DEPLOY_KEY_SECRET_REFdefault fromSSH_PRIVATE_KEYto empty (opt-in)Test plan
--secrets-provider— should start without errors--secrets-provider=bitwarden— should work as before--deploy-key-secret-refset — should fail with clear errorgo build ./...andgo vet ./...pass🤖 Generated with Claude Code