Merged
Conversation
Collaborator
Author
This was referenced Jan 26, 2022
Collaborator
|
@vvakame Hey, so I'm noticing this is causing some problems with 99designs/gqlgen#1857 and Khan/genqlient#166 that I wonder if you have any insights into? |
Collaborator
Author
|
sorry, I don't have any insight. what is the problem? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
current importer can't reproducable.
We can't know
what version of graphql-js does we use?.Current implementations use
e6c36e0725ea0aabad1a19c68e54180fb7092e3a.latest commit of
values_of_correct_type.goisJul 19, 2018.https://github.com/vektah/gqlparser/commits/master/validator/rules/values_of_correct_type.go
I picked up it from https://github.com/graphql/graphql-js/commits/master/src/validation/rules/ValuesOfCorrectType.js .
e6c36eis made atJul 18, 2018.So, I tried to update latest one. But I can't solve flowtype issue... 😿
https://github.com/vvakame/gqlparser/commits/improve-importer-r3
vvakame@895df5c
Do you advanced to babel & flowtype ...?