Update workflow sandbox mock then outputs generation#3308
Open
NgoHarrison wants to merge 1 commit intomainfrom
Open
Update workflow sandbox mock then outputs generation#3308NgoHarrison wants to merge 1 commit intomainfrom
NgoHarrison wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
|
@codex review |
NgoHarrison
force-pushed
the
harrison/fix-mocks-in-scenarios
branch
from
55b49a8 to
4749bf8
Compare
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
dvargas92495
reviewed
Dec 6, 2025
| node_id: string; | ||
| when_condition?: WorkflowValueDescriptor; | ||
| then_outputs: Record<string, unknown>; | ||
| then_outputs: Record<string, unknown> | WorkflowSandboxDatasetRowMockOutput[]; |
Contributor
There was a problem hiding this comment.
[blocking] this should never be the case from django... would love to see where this is coming from
| @@ -1,5 +1,42 @@ | |||
| // Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html | |||
|
|
|||
| exports[`Workflow Sandbox > write > should generate DatasetRow with mocks using array format for then_outputs 1`] = ` | |||
Contributor
There was a problem hiding this comment.
Even if this was a bug that we wanted to handle, the sandbox.py file shouldn't be used in the executions path at all and would be surprised if it was blocking the customer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.