Add manual trigger file generation in codegen#3676
Draft
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Draft
Add manual trigger file generation in codegen#3676devin-ai-integration[bot] wants to merge 2 commits intomainfrom
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Conversation
- Create ManualTrigger generator class following the pattern of other triggers - Update generateTriggerFiles() to handle MANUAL trigger type - Update getTriggerClassInfo() to return generated trigger path for MANUAL - Fix ManualTrigger serializer to not duplicate type field in objectSchema - Add test fixture for manual trigger codegen - Update integration test fixture to remove ENTRYPOINT node Co-Authored-By: harrison@vellum.ai <harrison.ngo719@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: harrison@vellum.ai <harrison.ngo719@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for generating Python trigger files for MANUAL triggers in codegen, enabling workflows to use manual triggers without requiring ENTRYPOINT nodes. This follows the same pattern as SCHEDULED, INTEGRATION, and CHAT_MESSAGE triggers.
Key changes:
ManualTriggergenerator class that extendsBaseTriggergenerateTriggerFiles()to handle MANUAL trigger typegetTriggerClassInfo()to return generated trigger path instead of built-in pathManualTriggerSerializerto not includetypefield in objectSchema (matches pattern of other trigger serializers where unionSchema discriminator handles type separately)Review & Testing Checklist for Human
generate-code.test.ts.snap)typefield removal follows the same pattern as other trigger serializersTest Plan
cd ee/codegen && npm testpoetry run pytest ee/codegen_integration/test_code_to_display.py -k "simple_manual_trigger_workflow"Notes
ManualTrigger)