[APO-2882] Add validation for required inputs in DatasetRow serialization#3677
Draft
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Draft
[APO-2882] Add validation for required inputs in DatasetRow serialization#3677devin-ai-integration[bot] wants to merge 2 commits intomainfrom
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Conversation
When a workflow has required input variables but a scenario has no inputs and no trigger, the serialization now raises a validation error instead of silently producing invalid data. Co-Authored-By: harrison@vellum.ai <harrison.ngo719@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: harrison@vellum.ai <harrison.ngo719@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds validation during workflow serialization to detect when a DatasetRow has no inputs and no trigger, but the workflow has required input variables. This prevents silently producing invalid sandbox configurations that would fail at runtime.