Merged
Conversation
rmichalak
force-pushed
the
robertmichalak/smoke-tests-in-ci
branch
from
57eb50d to
4774f78
Compare
rmichalak
commented
Dec 7, 2022
|
|
||
| jobs: | ||
| aarch64-apple-darwin: | ||
| aarch64-apple-darwin-release: |
Author
There was a problem hiding this comment.
I renamed these jobs to avoid name conflicts with the jobs defined in build.yml.
rmichalak
changed the title
allenap
approved these changes
Dec 7, 2022
| toolchain: stable | ||
| override: true | ||
| target: x86_64-unknown-linux-musl | ||
| - uses: Swatinem/rust-cache@v1 |
Contributor
There was a problem hiding this comment.
You may get warnings from GitHub that @v1 is out of date. I believe @v2 is enough to resolve this, i.e. there's nothing else you need to do except change the version.
Author
There was a problem hiding this comment.
Not precisely the goal of this PR, but I also updated action versions to get rid of GH warnings.
I couldn't get rid of every warning because some actions do not have never versions released. Some PRs to track:
actions-rs/toolchain#220
actions-rs/cargo#223
jelder
approved these changes
Dec 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added smoke tests to ensure the binary we produce can be executed.
for MacOS ARM64, we are cross-compiling as there's currently no support for MacOS ARM64 image in GH Actions.
Due to the cross-compilation, we can't run a smoke test there.