Skip to content

Fix undefined behavior in StartElevated stderr read loop (#1550) #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
idrassi merged 1 commit into from
Apr 23, 2026
Merged

Fix undefined behavior in StartElevated stderr read loop (#1550) #1687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Core/Unix/CoreService.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,9 +503,9 @@ namespace VeraCrypt
throw_sys_if (fcntl (outPipe->GetReadFD(), F_SETFL, O_NONBLOCK) == -1);
throw_sys_if (fcntl (errPipe.GetReadFD(), F_SETFL, O_NONBLOCK) == -1);

vector <char> buffer (4096), errOutput (4096);
buffer.clear ();
errOutput.clear ();
char buffer[4096];
vector <char> errOutput;
errOutput.reserve (4096);

Poller poller (outPipe->GetReadFD(), errPipe.GetReadFD());
int status, waitRes;
Expand All @@ -518,10 +518,10 @@ namespace VeraCrypt
ssize_t bytesRead = 0;
foreach (int fd, poller.WaitForData (timeout))
{
bytesRead = read (fd, &buffer[0], buffer.capacity());
bytesRead = read (fd, buffer, sizeof (buffer));
if (bytesRead > 0 && fd == errPipe.GetReadFD())
{
errOutput.insert (errOutput.end(), buffer.begin(), buffer.begin() + bytesRead);
errOutput.insert (errOutput.end(), buffer, buffer + bytesRead);

if (bytesRead > 5 && bytesRead < 80) // Short message captured
timeout = 200;
Expand Down
Loading