feat: support external emulator plugins#67
Open
jsj wants to merge 2 commits intovercel-labs:mainfrom
Open
Conversation
Contributor
|
@jsj is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0d21292529
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
emulate already uses a plugin-shaped internal architecture through per-service packages and ServicePlugin, but new emulators still require hardcoded core registry changes. This change reuses that existing service-entry path to allow external plugins while preserving built-in behavior and keeping scope limited to loading, listing, init, and programmatic startup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a small external-plugin loading path on top of the existing
ServicePluginarchitecture.This keeps built-in emulators unchanged, but lets teams run emulator packages that are not ready or appropriate for core yet:
Programmatic usage also works:
Why this matters
The volume of emulator PRs since this was opened is the signal: service coverage is valuable, but every new provider currently has to land as a core registry/package change. That makes the project carry every niche, experimental, or company-specific emulator forever.
This PR gives maintainers a lower-risk answer:
start,init,list, seed config, auth fallback, and programmatic APIs.Low-risk shape
ServicePluginis reused; no new runtime abstraction.--plugin/plugins.init allincludes external plugins only when explicitly supplied.Plugin contract
A plugin module exports a
ServicePluginas eitherpluginor default export.Optional exports:
seedFromConfiglabelendpointsdefaultFallbackinitConfigThe tests include a tiny
echo-plugin.tsfixture to make the contract concrete and reviewable.Test plan
pnpm --filter emulate type-checkpnpm --filter emulate testpnpm --filter emulate lint