Added full support for Nuget package resolution#23
Open
pingu2k4 wants to merge 1 commit intovercel-labs:mainfrom
Open
Added full support for Nuget package resolution#23pingu2k4 wants to merge 1 commit intovercel-labs:mainfrom
pingu2k4 wants to merge 1 commit intovercel-labs:mainfrom
Conversation
|
@pingu2k4 is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
Comment on lines
+82
to
+83
| const [aCore, aPre] = aMain.split("-", 2); | ||
| const [bCore, bPre] = bMain.split("-", 2); |
There was a problem hiding this comment.
Suggested change
| const [aCore, aPre] = aMain.split("-", 2); | |
| const [bCore, bPre] = bMain.split("-", 2); | |
| const aHyphen = aMain.indexOf("-"); | |
| const aCore = aHyphen >= 0 ? aMain.slice(0, aHyphen) : aMain; | |
| const aPre = aHyphen >= 0 ? aMain.slice(aHyphen + 1) : undefined; | |
| const bHyphen = bMain.indexOf("-"); | |
| const bCore = bHyphen >= 0 ? bMain.slice(0, bHyphen) : bMain; | |
| const bPre = bHyphen >= 0 ? bMain.slice(bHyphen + 1) : undefined; |
compareNuGetVersions truncates prerelease labels containing hyphens (e.g., dev-02419 becomes dev), causing distinct prerelease versions to compare as equal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for NuGet packages to the
opensrcCLI tool, enabling source code fetching, listing, and removal for .NET packages alongside existing npm, PyPI, and crates.io registries. It also introduces command-line options and documentation updates to reflect NuGet support. The most important changes are grouped below:NuGet Registry Support
dotnet:,nupkg:) for NuGet packages. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Command Enhancements
--allow-prereleaseoption to fetch the latest NuGet package including prerelease versions, wired through CLI and fetch logic. [1] [2] [3] [4] [5] [6] [7] [8]Documentation Updates
README.mdandAGENTS.mdto document NuGet support, CLI usage examples, and registry aliases. [1] [2] [3] [4] [5]Testing
Path Handling
joinfor improved cross-platform compatibility. [1] [2]These changes collectively enable seamless handling of NuGet packages in the
opensrctool, making it more useful for .NET developers and teams.