fix: VS Code extension activation and YAML file support#35
Merged
Conversation
- Add mainFields to esbuild config so jsonc-parser ESM build is used, fixing the unbundled ./impl/format require - Add onCommand activation event so the command works before the editor/panel is opened - Support dockercompose, github-actions-workflow, and home-assistant language IDs
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
There was a problem hiding this comment.
Additional Suggestion:
The syncWithActiveEditor method in panel-provider.ts only accepts json, jsonc, and yaml language IDs, causing the panel to reject docker-compose, GitHub Actions workflow, and Home Assistant YAML files despite those being enabled in the when clause and command handler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cannot find module './impl/format'by addingmainFields: ["module", "main"]to esbuild config sojsonc-parserESM build is bundled instead of UMDonCommand:visualJson.openWithVisualJsonactivation event so the command works before the custom editor or panel is openeddocker-compose.ymland other YAML-derived language IDs (dockercompose,github-actions-workflow,home-assistant)