fix(serialize): restore altScreen mode before writing payload#40
Closed
emmanuel-martinez-dev wants to merge 2 commits into
Closed
fix(serialize): restore altScreen mode before writing payload#40emmanuel-martinez-dev wants to merge 2 commits into
emmanuel-martinez-dev wants to merge 2 commits into
Conversation
Adds a new package that serializes wterm terminal state (grid, scrollback, cursor, modes) into a portable snapshot and restores it into a fresh terminal, matching the capability xterm.js users get from @xterm/addon-serialize. Closes vercel-labs#35.
Fixes the order issue reported by Vercel bot where content was being written before switching to alternate screen, causing it to be hidden. Now altScreen mode is enabled first, then payload + other modes + cursor.
|
@emmanuel-martinez-dev is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the alternate screen restore order issue reported by the Vercel bot in #36.
Changes
\x1b[?1049h(enter altScreen) before writing the serialized payloadcursorKeysApp,bracketedPaste)This ensures that content written to the alternate screen is not lost/hidden after restore.
Tested locally with altScreen snapshots — restoration now works correctly.
Related to: #36