Fix stale DataView after WASM memory growth#65
Open
hobostay wants to merge 1 commit into
Open
Conversation
The cached _dv DataView becomes invalid when WASM memory grows (detached ArrayBuffer), causing TypeError on subsequent getCell() and getScrollbackCell() calls. Create a fresh DataView from this.memory.buffer on each access instead of caching it. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Someone is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WasmBridgecaching aDataView(_dv) that becomes invalid when WASM memory grows (buffer detaches)getCell()andgetScrollbackCell()now create a freshDataViewfromthis.memory.bufferon each call instead of using the cached referenceTypeError: Cannot perform DataView.prototype.getUint32 on a detached ArrayBufferafter memory growthRoot cause
WebAssembly.Memory.grow()creates a newArrayBufferand detaches the old one. The_dvwas only refreshed in_updatePointers()(called frominit()andresize()), but WASM memory can grow at any time duringwriteBytes().Test plan
pnpm test🤖 Generated with Claude Code