Fix GhosttyCore scrollback cells rendering with black colors#66
Open
hobostay wants to merge 1 commit intovercel-labs:mainfrom
Open
Fix GhosttyCore scrollback cells rendering with black colors#66hobostay wants to merge 1 commit intovercel-labs:mainfrom
hobostay wants to merge 1 commit intovercel-labs:mainfrom
Conversation
getScrollbackCell() unconditionally packed RGB values into fgRgb/bgRgb even when colorFlags indicated no explicit color was set. This caused scrollback lines to render with rgb(0,0,0) instead of using terminal default colors. Now matches getCell()'s logic by checking colorFlags before setting fgRgb/bgRgb. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Someone is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getScrollbackCell()in@wterm/ghosttyunconditionally packing RGB values intofgRgb/bgRgbeven whencolorFlagsindicates no explicit color was setrgb(0,0,0)(black) foreground/background instead of using terminal default colorscolorFlagscheck pattern used bygetCell()Before
After
Test plan
🤖 Generated with Claude Code