Fix WebSocket reconnect delay not resetting on new connect()#67
Open
hobostay wants to merge 1 commit intovercel-labs:mainfrom
Open
Fix WebSocket reconnect delay not resetting on new connect()#67hobostay wants to merge 1 commit intovercel-labs:mainfrom
hobostay wants to merge 1 commit intovercel-labs:mainfrom
Conversation
connect() did not reset _reconnectDelay, so if a previous session had backed off to the maximum delay (e.g. 30s), a new connect() call would still use that stale value. Reset to 1000ms at the start of each new connection attempt. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Someone is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| if (!this.url) throw new Error("No WebSocket URL provided"); | ||
|
|
||
| this._closed = false; | ||
| this._reconnectDelay = 1000; |
There was a problem hiding this comment.
Exponential backoff for WebSocket reconnection is broken because connect() unconditionally resets _reconnectDelay to 1000ms, and _scheduleReconnect() calls connect() internally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WebSocketTransport.connect()not resetting_reconnectDelaywhen starting a new connectionconnect()again would inherit that stale delay instead of starting fresh_reconnectDelayis now reset to1000at the start ofconnect(), consistent with the reset that happens ononopenHow to reproduce
connect()again — without this fix, the first reconnect attempt waits 30s instead of 1sTest plan
🤖 Generated with Claude Code