Fix writeRaw buffer view invalidation on WASM memory growth#68
Open
hobostay wants to merge 1 commit intovercel-labs:mainfrom
Open
Fix writeRaw buffer view invalidation on WASM memory growth#68hobostay wants to merge 1 commit intovercel-labs:mainfrom
hobostay wants to merge 1 commit intovercel-labs:mainfrom
Conversation
writeRaw() created a single Uint8Array view of WASM memory before the write loop. If writeBytes() triggers WASM memory growth, the buffer detaches and subsequent iterations fail. Create a fresh view in each loop iteration to handle memory growth correctly. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Someone is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
writeRaw()inWasmBridgecreating a singleUint8Arrayview before the write loopwriteBytes()triggers WASM memory growth (buffer detaches), subsequent iterations of the loop would fail because the view references a detachedArrayBufferUint8Arrayview in each loop iteration to handle potential memory growthRoot cause
WebAssembly.Memory.grow()detaches the oldArrayBuffer. The write loop reuses the samebufview across iterations, butwriteBytes()can trigger memory growth internally.Test plan
pnpm test🤖 Generated with Claude Code