Fix escapeHTML missing double quote escaping#69
Open
hobostay wants to merge 1 commit into
Open
Conversation
escapeHTML is used to sanitize text before injecting into innerHTML via style attributes (<span style="...">). Without escaping double quotes, text content containing " could break out of the style attribute. Add " escaping for defense in depth. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Someone is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
escapeHTML()in@wterm/domrenderer not escaping double quotes (")innerHTMLvia<span style="${runStyle}">— unescaped"could theoretically break out of the style attribute"replacement for defense in depthTest plan
pnpm test🤖 Generated with Claude Code