fix(ai): correct mock array result indexing#15154
Conversation
|
Kage usage for this PR: This PR fixed #15141 by correcting array-backed mock result indexing across the AI SDK mock language and embedding models. How Kage helped:
Why this matters for future sessions: Full contribution summary and Kage metrics: kage-core/Kage#8 |
6bb0deb to
3234eb5
Compare
|
Please sign your commits, otherwise I cannot merge the PR https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
3234eb5 to
287b5d4
Compare
|
@lgrammel |
|
tests are now failing |
9a47ab8 to
56a0115
Compare
|
I checked the failed run. The failing job was |
56a0115 to
ace15da
Compare
|
🚀 Published in:
|
## Summary - corrects array-backed indexing in `MockLanguageModelV3` / `MockLanguageModelV4` for `doGenerate` and `doStream` - corrects the same off-by-one in `MockEmbeddingModelV3` / `MockEmbeddingModelV4` for `doEmbed` - adds focused tests that verify the first call returns the first scripted result and the second call returns the second scripted result - adds a patch changeset for `ai` ## Verification - `pnpm --filter ai exec vitest --config vitest.node.config.js --run src/test/mock-language-model.test.ts src/test/mock-embedding-model.test.ts` - `pnpm --filter ai type-check` - `pnpm type-check:full` - `pnpm exec ultracite check packages/ai/src/test/mock-language-model.test.ts packages/ai/src/test/mock-embedding-model.test.ts packages/ai/src/test/mock-language-model-v3.ts packages/ai/src/test/mock-language-model-v4.ts packages/ai/src/test/mock-embedding-model-v3.ts packages/ai/src/test/mock-embedding-model-v4.ts .changeset/slow-mocks-learn.md` Note: local verification ran on Node `v25.9.0`, so pnpm emitted the repo's unsupported-engine warning. The commands still passed. ## Related Issues Fixes #15141
Summary
Fixes #15141.
MockLanguageModelV3/MockLanguageModelV4fordoGenerateanddoStreamMockEmbeddingModelV3/MockEmbeddingModelV4fordoEmbedaiVerification
pnpm --filter ai exec vitest --config vitest.node.config.js --run src/test/mock-language-model.test.ts src/test/mock-embedding-model.test.tspnpm --filter ai type-checkpnpm type-check:fullpnpm exec ultracite check packages/ai/src/test/mock-language-model.test.ts packages/ai/src/test/mock-embedding-model.test.ts packages/ai/src/test/mock-language-model-v3.ts packages/ai/src/test/mock-language-model-v4.ts packages/ai/src/test/mock-embedding-model-v3.ts packages/ai/src/test/mock-embedding-model-v4.ts .changeset/slow-mocks-learn.mdNote: local verification ran on Node
v25.9.0, so pnpm emitted the repo's unsupported-engine warning. The commands still passed.