fix(provider/google-vertex): support embedding model settings#15325
Open
Kage18 wants to merge 1 commit into
Open
fix(provider/google-vertex): support embedding model settings#15325Kage18 wants to merge 1 commit into
Kage18 wants to merge 1 commit into
Conversation
Contributor
Author
|
Kage usage for this PR: This PR fixed #7262 by allowing default embedding settings on How Kage helped:
Why this matters for future sessions: Full contribution summary and Kage metrics: kage-core/Kage#8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7262.
vertex.textEmbeddingModel()is documented with an optional settings argument such as{ outputDimensionality }, but the provider type and constructor path only accepted a model id.This adds optional default embedding settings to:
vertex.embeddingModel(modelId, settings)vertex.textEmbeddingModel(modelId, settings)The defaults are merged into embedding requests, and per-call provider options still take precedence.
Tests