feat(slack): resolve @displayname mentions to <@USER_ID> in outgoing messages#230
Merged
feat(slack): resolve @displayname mentions to <@USER_ID> in outgoing messages#230
Conversation
…messages Build a reverse index from display name → user IDs during lookupUser(), track thread participants on incoming messages, and resolve @name mentions to Slack's <@USER_ID> format before sending. Disambiguates using thread participants when multiple users share a display name. Also increases user/channel cache TTLs to 8 days. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
matchai
approved these changes
Mar 13, 2026
Member
matchai
left a comment
matchai
left a comment
There was a problem hiding this comment.
Non-blocking but might be worth holding off until we address cache busting.
packages/adapter-slack/src/index.ts
Outdated
Comment on lines
+2024
to
+2028
| return text.replace(mentionPattern, (match, name: string) => { | ||
| const idx = text.indexOf(match); | ||
| if (idx > 0 && text[idx - 1] === "<") { | ||
| return match; | ||
| } |
Member
There was a problem hiding this comment.
In the event of two mentions in the same message, this indexOf will resolve to the first instance for every match. Patched up by using the offset:
Suggested change
| return text.replace(mentionPattern, (match, name: string) => { | |
| const idx = text.indexOf(match); | |
| if (idx > 0 && text[idx - 1] === "<") { | |
| return match; | |
| } | |
| return text.replace(mentionPattern, (match, name: string, offset: number) => { | |
| if (offset > 0 && text[offset - 1] === "<") { | |
| return match; | |
| } |
| private readonly formatConverter = new SlackFormatConverter(); | ||
| private static USER_CACHE_TTL_MS = 60 * 60 * 1000; // 1 hour | ||
| private static CHANNEL_CACHE_TTL_MS = 60 * 60 * 1000; // 1 hour | ||
| private static USER_CACHE_TTL_MS = 8 * 24 * 60 * 60 * 1000; // 8 days |
Member
There was a problem hiding this comment.
The userId → displayName mapping will be stale here for 8 days. This'll cause cosmetic issues with the agent using an old user name after a name change for to up to 8 days.
We have users:read in the manifest so we should subscribe to user_change events for cache invalidation.
…he on user_change
…date cache on user_change" This reverts commit 8cb0d90.
Member
|
@cramforce I've gone ahead and stacked #236 on your PR to implement cache invalidation 👍 |
…he on user_change (#236) * fix(slack): use replace offset for duplicate mentions, invalidate cache on user_change * style: align handleUserChange to async/await, expand changeset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build a reverse index from display name → user IDs during lookupUser(), track thread participants on incoming messages, and resolve @name mentions to Slack's <@USER_ID> format before sending. Disambiguates using thread participants when multiple users share a display name. Also increases user/channel cache TTLs to 8 days.