benpankow/unsubscribe rd 2#1177
Draft
benpankow wants to merge 2 commits into
Draft
Conversation
Signed-off-by: benpankow <ben.pankow@vercel.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| const delivery = readSlackMessageDeliveryData(payload.channelData); | ||
| if (delivery === undefined) return defaultDeliverResult(payload); | ||
|
|
||
| const current = adapterCtx.state.subscription as SlackSubscriptionState; |
Contributor
There was a problem hiding this comment.
Suggested change
| const current = adapterCtx.state.subscription as SlackSubscriptionState; | |
| const current = (adapterCtx.state.subscription ?? "subscribed") as SlackSubscriptionState; |
Pre-existing Slack sessions lack a serialized subscription field, so current is undefined and the first non-mention message throws a misleading resolver error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
How did you test your changes?
PR Checklist
CONTRIBUTING.mdevepackagegit commit --signoff)Stack created with GitHub Stacks CLI • Give Feedback 💬