feat(eve): add ability to unsubscribe eve from Slack threads (v3)#1178
Draft
benpankow wants to merge 2 commits into
Draft
feat(eve): add ability to unsubscribe eve from Slack threads (v3)#1178benpankow wants to merge 2 commits into
benpankow wants to merge 2 commits into
Conversation
Signed-off-by: benpankow <ben.pankow@vercel.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| const delivery = readSlackMessageDeliveryData(payload.channelData); | ||
| if (delivery === undefined) return defaultDeliverResult(payload); | ||
|
|
||
| const current = adapterCtx.state.subscription as SlackSubscriptionState; |
Contributor
There was a problem hiding this comment.
Suggested change
| const current = adapterCtx.state.subscription as SlackSubscriptionState; | |
| // Durable sessions created before `subscription` was added to | |
| // `SlackChannelState` have no persisted value here. Default a | |
| // missing/invalid value to "subscribed" so legacy threads follow | |
| // (rather than throwing when the default resolver returns `current`). | |
| const current: SlackSubscriptionState = | |
| adapterCtx.state.subscription === "unsubscribed" ? "unsubscribed" : "subscribed"; |
Legacy durable Slack sessions lacking the new subscription state field cause the deliver hook to throw (session.failed) on non-mention messages instead of following/ignoring the thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This exploratory PR adds durable Slack thread subscriptions using the existing per-session Slack channel state, without introducing another storage method or adding framework-level code (entirely internal to Slack state).
The API progresses from mention-only behavior, to following active threads, to a custom subscription lifecycle.
1. Respond only to explicit mentions
This remains the default:
2. Respond to replies in active threads
Messages outside active eve threads remain ignored.
3. Refine when a thread remains subscribed
The resolver runs inside the durable session after state is hydrated. Returning
"subscribed"dispatches the message; returning"unsubscribed"persists the state and ignores it before model execution. Explicit mentions can resubscribe the same session while preserving its history and state.Test Plan