Skip to content

fix(eve): keep approvals pending across a same-step runtime action#1200

Open
ruiconti wants to merge 1 commit into
mainfrom
rui/approval-runtime-action-collision
Open

fix(eve): keep approvals pending across a same-step runtime action#1200
ruiconti wants to merge 1 commit into
mainfrom
rui/approval-runtime-action-collision

Conversation

@ruiconti

@ruiconti ruiconti commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Fixes #1201.

When a single model step requested an approval-gated tool call and a subagent (or remote-agent) call together, the approval was silently dropped and the turn then failed on resume.

Runtime artifact

AI_MissingToolResultsError: Tool result is missing for tool call call_I4tnJrVHUKMpLUpQowurUKso.

Cause

The park classification returned on the runtime-action batch before the input-request park ran. So input.requested was never emitted for the approval, and when the action result arrived and resumed the step, the model was called with the gated tool call's tool_use still unanswered — the AI SDK rejects that.

Fix

The classification now persists both batches — the input batch with empty responseMessages, since the action batch owns the step's assistant messages — and emits input.requested immediately. On the action-result resume, the existing staged resolution in executeStepBody re-parks on the still-unanswered approval, committing the resolved action results to history and closing the turn with the standard waiting boundary.

Standalone harness fix, independent of the event-lane work it was found alongside. Regression test: parks on both batches when one step carries a runtime action and an approval.

When one model step requested both an approval-gated tool call and a
runtime action (subagent or remote-agent call), the park classification
returned on the runtime-action batch before the input-request park ran,
silently dropping the approval: input.requested was never emitted, and
the action-result resume called the model with the gated call's tool_use
still unanswered — AI_MissingToolResultsError, failing the turn.

The classification now persists both batches (the input batch with empty
responseMessages, since the action batch owns the step's assistant
messages) and emits input.requested immediately. On the action-result
resume, executeStepBody's existing staged resolution re-parks on the
still-unanswered batch, committing the resolved action results to
history and closing the turn with the standard waiting boundary.

Signed-off-by: Rui Conti <ruiconti@gmail.com>
@vercel

vercel Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
eve-docs Ready Ready Preview, Comment, Open in v0 Jul 25, 2026 12:29am
eve-docs-1644 Ready Ready Preview, Comment, Open in v0 Jul 25, 2026 12:29am
eve-docs-4759 Ready Ready Preview, Comment, Open in v0 Jul 25, 2026 12:29am

@github-actions

Copy link
Copy Markdown
Contributor

Bundle + Package Summary: apps/fixtures/weather-agent

Key takeaways

  • No notable deltas vs main (0a8b63c).

Delta vs main (0a8b63c)

Area Metric Baseline Current Delta
Package Packed tarball 4.06 MB 4.06 MB -105 B ✅
Package Unpacked publish size 14.75 MB 14.75 MB +494 B ⚠️
Package Installed footprint 53.91 MB 53.91 MB +494 B ⚠️
Package Published files 2773 2773 0
Package Installed files 6013 6013 0
Runtime Unique function payloads 2 2 0
Runtime Total function bytes 11.68 MB 11.68 MB +640 B ⚠️
Runtime Public routes 11 11 0
Changed function payloads vs main (0a8b63c) (2)
Function Status Baseline Current Delta Route changes
functions/.well-known/workflow/v1/flow.func changed 7.27 MB 7.27 MB +660 B ⚠️ none
functions/__server.func changed 4.41 MB 4.41 MB -20 B ✅ none

eve init install

Metric Baseline Current Delta
Installed footprint 92.31 MB 92.31 MB +494 B ⚠️
Installed packages 122 122 0
dependencies 4 4 0
devDependencies 2 2 0
Dependency package bytes 29.03 MB 29.03 MB +494 B ⚠️
devDependency package bytes 5.04 MB 5.04 MB 0 B ➖
Build Metadata
  • Preset: vercel
  • Nitro: nitro@3.0.260610-beta
  • Output directory: apps/fixtures/weather-agent/.vercel/output
  • Build metadata timestamp: 2026-07-25T00:29:49.459Z
  • Route aliases: 11 public, 1 internal (12 total aliases)
  • Vercel routes in config: 12
  • Severity legend: 🔴 dominant/large, 🟠 notable, 🟡 watch, ⚪ small
Package Drill-Down

Package Details

  • Package: eve@0.27.5
  • Package directory: packages/eve
  • Tarball: 4.06 MB (eve-0.27.5.tgz)
  • Unpacked payload: 14.75 MB across 2773 published files
  • Installed footprint: 53.91 MB across 6013 installed files
  • Installed root package: 13.47 MB
  • Installed dependencies: 40.44 MB
  • Runtime dependencies: 1
  • Peer dependencies: 5 (4 optional)

Installed footprint is measured from an isolated temporary npm install of the packed tarball.

Heavy installed dependencies

  • @rolldown/binding-linux-x64-gnu: 18.96 MB (35.2%)
  • eve: 13.47 MB (25.0%)
  • ai: 6.43 MB (11.9%)
  • zod: 5.04 MB (9.3%)
  • nitro: 2.41 MB (4.5%)
Publish payload breakdown
Published file size
🟠 dist/src/compiled/experimental-ai-sdk-code-mo... [###.....................] 1.51 MB 10.2%
🟡 dist/src/compiled/@vercel/sandbox/index.js       [#.......................] 632.4 kB 4.3%
🟡 dist/src/compiled/_chunks/workflow/undici-C2Z... [#.......................] 502.4 kB 3.4%
🟡 dist/src/compiled/@chat-adapter/slack/index.js   [#.......................] 440.5 kB 3.0%
🟡 dist/src/compiled/@vercel/oidc/index.js          [#.......................] 379.5 kB 2.6%
🔴 Other published files                            [########################] 11.29 MB 76.5%
Installed footprint breakdown
Installed package size
🔴 @rolldown/binding-linux-x64-gnu [########################] 18.96 MB 35.2%
🔴 eve                             [#################.......] 13.47 MB 25.0%
🔴 ai                              [########................] 6.43 MB 11.9%
🔴 zod                             [######..................] 5.04 MB 9.3%
🟠 nitro                           [###.....................] 2.41 MB 4.5%
🟡 @ai-sdk/provider-utils          [#.......................] 852.0 kB 1.6%
🔴 Other installed packages        [#########...............] 6.75 MB 12.5%
Runtime dependencies (1)
Package Range Notes
nitro 3.0.260610-beta
Peer dependencies (5)
Package Range Notes
@opentelemetry/api ^1.0.0 optional peer
ai catalog:
braintrust ^3.0.0 optional peer
just-bash ^3.0.0 optional peer
microsandbox ^0.5.0 optional peer
eve init install drill-down

eve init install details

  • Command: eve init my-agent
  • Package manager: npm
  • Installed footprint: 92.31 MB across 7881 installed files
  • Installed packages: 122 total (116 transitive-only)
  • dependencies: 4 direct packages totaling 29.03 MB
  • devDependencies: 2 direct packages totaling 5.04 MB
  • Other transitive package files: 58.24 MB

Installed footprint is measured from an isolated temporary eve init my-agent using the current packed eve tarball.

Heavy installed dependencies

  • @typescript/typescript-linux-x64: 27.95 MB (30.3%)
  • @rolldown/binding-linux-x64-gnu: 18.96 MB (20.5%)
  • eve: 13.47 MB (14.6%)
  • zod: 9.00 MB (9.7%)
  • ai: 6.43 MB (7.0%)
Installed footprint breakdown
Installed package size
🔴 @typescript/typescript-linux-x64 [########################] 27.95 MB 30.3%
🔴 @rolldown/binding-linux-x64-gnu  [################........] 18.96 MB 20.5%
🔴 eve                              [############............] 13.47 MB 14.6%
🔴 zod                              [########................] 9.00 MB 9.7%
🔴 ai                               [######..................] 6.43 MB 7.0%
🟠 @types/node                      [##......................] 2.54 MB 2.8%
🔴 Other installed packages         [############............] 13.97 MB 15.1%
dependencies (4)
Package Range Installed size Share
@vercel/connect 0.4.2 135.8 kB 0.1%
ai ^7.0.34 6.43 MB 7.0%
eve file:eve-0.27.5.tgz 13.47 MB 14.6%
zod 4.4.3 9.00 MB 9.7%
devDependencies (2)
Package Range Installed size Share
@types/node 24.x 2.54 MB 2.8%
typescript 7.0.2 2.50 MB 2.7%
Function Drill-Down

Payload Size Graph

Unique function payload size and share of total
🔴 functions/.well-known/workflow/v1/flow.func     [########################] 7.27 MB 62.2%
🟠 functions/__server.func                         [###############.........] 4.41 MB 37.8%

Top Function Payloads

🟠 functions/.well-known/workflow/v1/flow.func • 1 public route • 7.27 MB
Metric Value
Public routes /.well-known/workflow/v1/flow
Runtime nodejs24.x
Handler index.mjs
Payload 7.27 MB
Function files 7.27 MB across 39 files
Traced dependencies 0 B
Signal 🟠 Bundled file __eve_nitro_handler__.mjs is 2.71 MB (37.2%)

🟠 🔎 Dependency Analysis

📦 Bundled files:

Bundled file size
🟠 __eve_nitro_handler__.mjs       [########################] 2.71 MB 37.2%
🟡 _chunks/world-vercel.mjs        [########................] 903.2 kB 12.4%
🟡 _chunks/sandbox.mjs             [#######.................] 767.6 kB 10.6%
🟡 _libs/@ai-sdk/gateway+[...].mjs [####....................] 432.5 kB 5.9%
🟡 _chunks/token-util-B6qBs3-0.mjs [###.....................] 379.1 kB 5.2%
🟠 Other bundled files             [##################......] 2.08 MB 28.6%

🧾 Vercel Config

{
  "handler": "index.mjs",
  "launcherType": "Nodejs",
  "shouldAddHelpers": false,
  "supportsResponseStreaming": true,
  "runtime": "nodejs24.x",
  "environment": {
    "WORKFLOW_PRECONDITION_GUARD": "1",
    "NODE_OPTIONS": "--experimental-require-module"
  },
  "maxDuration": "max",
  "experimentalTriggers": [
    {
      "type": "queue/v2beta",
      "topic": "__eve776561746865722d6167656e74_wkf_workflow_*",
      "consumer": "default",
      "retryAfterSeconds": 5,
      "initialDelaySeconds": 0
    }
  ]
}

🟠 functions/__server.func • 10 public routes, 1 internal alias • 4.41 MB
Metric Value
Public routes /
/eve/v1/callback/[token]
/eve/v1/connections/[name]/callback/[token]
/eve/v1/health
/eve/v1/info
/eve/v1/session
/eve/v1/session/[sessionId]
/eve/v1/session/[sessionId]/cancel
/eve/v1/session/[sessionId]/stream
/eve/v1/session/reset
Internal aliases /__server
Runtime nodejs24.x
Handler index.mjs
Payload 4.41 MB
Function files 4.41 MB across 30 files
Traced dependencies 0 B
Signal 🟠 Bundled file _chunks/runtime-artifacts.mjs is 1.41 MB (32.0%)

🟠 🔎 Dependency Analysis

📦 Bundled files:

Bundled file size
🟠 _chunks/runtime-artifacts.mjs   [########################] 1.41 MB 32.0%
🟠 _chunks/world-vercel.mjs        [###############.........] 900.3 kB 20.4%
🟠 _chunks/sandbox.mjs             [#############...........] 767.6 kB 17.4%
🟡 _chunks/token-util-B6qBs3-0.mjs [######..................] 379.1 kB 8.6%
🟡 _chunks/dist-BX517Nmz.mjs       [######..................] 348.7 kB 7.9%
🟡 Other bundled files             [##########..............] 603.6 kB 13.7%

🧾 Vercel Config

{
  "handler": "index.mjs",
  "launcherType": "Nodejs",
  "shouldAddHelpers": false,
  "supportsResponseStreaming": true,
  "runtime": "nodejs24.x"
}

Build Timing: e2e/fixtures/agent-tools-sandbox

This is an informational timing measurement inside eve build, from preflight through publication. Output-size measurement and profile writing are excluded.

Build mode: deployable Vercel build with sandbox template prewarm included.

  • Build pipeline: 2.65 s -> 2.75 s (+100.7 ms) vs main (0a8b63c).
  • Timing is informational: shared GitHub runners are too variable for a hard timing budget.
Detailed phase timings vs `main (0a8b63c)`
Phase Baseline Current Delta
extension.check 1.1 ms 8.0 ms +6.9 ms
project.resolve 0.6 ms 1.4 ms +0.8 ms
workspace.create 0.8 ms 1.2 ms +0.4 ms
host.prepare 227.8 ms 207.5 ms -20.3 ms
vercel.service-prefix.resolve 2.4 ms 2.2 ms -0.2 ms
nitro.app.create 26.9 ms 25.9 ms -1.0 ms
nitro.app.cache.prepare 0.3 ms 0.3 ms 0.0 ms
nitro.app.prepare 1.0 ms 1.0 ms 0.0 ms
nitro.app.public-assets 0.8 ms 0.7 ms -0.1 ms
nitro.app.prerender 0.5 ms 0.6 ms +0.1 ms
nitro.app.bundle 693.7 ms 705.5 ms +11.8 ms
nitro.app.cache.write 0.4 ms 0.4 ms 0.0 ms
sandbox.prewarm 279.0 ms 284.3 ms +5.3 ms
nitro.flow.create 185.2 ms 205.6 ms +20.4 ms
nitro.flow.cache.prepare 0.2 ms 0.2 ms 0.0 ms
nitro.flow.prepare 0.8 ms 0.9 ms +0.1 ms
nitro.flow.public-assets 0.2 ms 0.2 ms 0.0 ms
nitro.flow.prerender 0.0 ms 0.0 ms 0.0 ms
nitro.flow.bundle 1.04 s 1.12 s +80.6 ms
nitro.flow.cache.write 0.3 ms 0.4 ms +0.1 ms
nitro.flow.close 0.2 ms 0.2 ms 0.0 ms
workflow.emit 182.3 ms 177.5 ms -4.8 ms
agent-summary.emit 0.5 ms 0.6 ms +0.1 ms
nitro.app.close 0.1 ms 0.1 ms 0.0 ms
output.publish 3.9 ms 4.2 ms +0.3 ms
workspace.remove 5.8 ms 6.0 ms +0.2 ms

@vercel vercel Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Suggestion:

The deferredMessage early-return branch in executeStepBody parks on the untouched session, dropping resolved runtime-action tool results from history when a resume carries both runtimeActionResults and a follow-up message (no approval response).

Fix on Vercel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Approval dropped when a step requests both an approval-gated tool and a subagent call

1 participant