Merged
Conversation
|
@emmamarichal is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
@skullface can we merge this please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @guidoferreyra!
Here you can find some tiny changes, in order to follow GF specs. These concern only Geist and Geist Mono (+italics).
For Pixel version, we will need to onboard a family for each kind of pixels, or, use a existing axis, to make a variable font with the element shape changing. What do you thing?
You can have a look at https://fonts.google.com/variablefonts?vfaxis=ELSH, with ELSH axis, that could be used here :)
Feel free if you have any questions!