Skip to content

feat: port ncc bundling pipeline to rspack#1304

Open
ScriptedAlchemy wants to merge 10 commits into
vercel:mainfrom
ScriptedAlchemy:llms-module-rspack-port-78c2
Open

feat: port ncc bundling pipeline to rspack#1304
ScriptedAlchemy wants to merge 10 commits into
vercel:mainfrom
ScriptedAlchemy:llms-module-rspack-port-78c2

Conversation

@ScriptedAlchemy
Copy link
Copy Markdown

@ScriptedAlchemy ScriptedAlchemy commented Feb 9, 2026 •
edited
Loading

Summary

  • Port ncc's internal bundling pipeline from webpack to rspack while preserving CLI behavior.
  • Keep resolver fallback, native asset relocation, and TypeScript loader behavior aligned with existing edge cases.
  • Update unit output fixtures for rspack-generated artifacts and refresh dependencies/lockfile changes.

Testing

  • Updated fixture outputs across affected unit cases.
  • CI on this PR validates behavior against the existing test suite.

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Feb 9, 2026 •
edited
Loading

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Addednpm/​@​swc/​wasm@​1.15.401001007296100
Addednpm/​@​rspack/​core@​1.7.11981008097100
Addednpm/​@​vercel/​webpack-asset-relocator-loader@​1.10.09710010087100
Addednpm/​@​swc/​core@​1.15.409210010095100

View full report

@ScriptedAlchemy ScriptedAlchemy changed the title feat: migrate to rspac feat: port ncc bundling pipeline to rspack Feb 9, 2026
styfle
styfle reviewed Feb 10, 2026
View reviewed changes
Comment thread scripts/build.js
styfle
styfle reviewed Feb 10, 2026
View reviewed changes
Comment thread src/loaders/ts-loader.js
cursoragent and others added 8 commits June 1, 2026 19:45
@cursoragent @ScriptedAlchemy
Add rspack core dependency
6bdea91 
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
@cursoragent @ScriptedAlchemy
Port ncc build to rspack
fc65602 
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
@cursoragent @ScriptedAlchemy
Fix resolver fallback and native asset handling
97aa65e 
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
@cursoragent @ScriptedAlchemy
Update unit fixtures for Rspack output
f76e76c 
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
@cursoragent @ScriptedAlchemy
Remove esbuild dev dependency
1aca476 
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
@cursoragent @ScriptedAlchemy
Harden rspack resolver fallback and ts-loader compatibility
0a5f0a2 
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
@ScriptedAlchemy @cursoragent
Fix watch callback forwarding for changed and removed files
439222f 
Handle both 4-argument and 5-argument watch callback signatures so changed and removed file sets are forwarded correctly and callbackUndelayed receives file metadata.

Co-authored-by: Cursor <cursoragent@cursor.com>
test: update ts-json-resolve rspack fixture after upstream sync
a764e3c
@ScriptedAlchemy ScriptedAlchemy force-pushed the llms-module-rspack-port-78c2 branch from 45bfde1 to a764e3c Compare June 1, 2026 17:49
@ScriptedAlchemy ScriptedAlchemy requested a review from styfle June 1, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Timer Timer Awaiting requested review from Timer

@styfle styfle Awaiting requested review from styfle

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ScriptedAlchemy @styfle @cursoragent