chore(ci): disable phantomjs-prebuilt postinstall that breaks CI installs#597
Merged
Conversation
ijjk
approved these changes
Jun 22, 2026
phantomjs-prebuilt (deprecated) downloads and extracts a binary from
GitHub releases in its postinstall to generate lib/location.js. The
extraction consistently fails on macOS/Windows ("Install exited
unexpectedly"), breaking `pnpm install` and CI regardless of the change
under test. Retrying does not help.
The nft trace test only relies on the phantomjs-prebuilt special case
emitting the bin/ directory; lib/location.js is just an install-time
artifact. Disable the postinstall build (pnpm allowBuilds) so installs
are reliable on every OS, and drop lib/location.js from the expected
trace output accordingly.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
styfle
force-pushed
the
fix/flaky-phantomjs-install
branch
from
391450f to
6d9d021
Compare
styfle
changed the title
styfle
changed the title
styfle
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Disable the
phantomjs-prebuiltpostinstall build (pnpmallowBuilds: false) and drop the install-generatedlib/location.jsfrom the expected trace fixture.Why
phantomjs-prebuiltis deprecated. Its postinstall downloads a 16MB binary from GitHub releases and extracts it to generatelib/location.js. The download succeeds, but the zip extraction consistently fails on macOS/Windows:This fails
pnpm installand breaks CI for any PR that touches dependencies (e.g. #596), and re-running doesn't help.The
test/unit/phantomjs-prebuiltfixture only exercises nft's special case that emits thebin/directory —lib/location.jsis just an install artifact, not part of the behavior under test. Skipping the build makes installs reliable on every OS while preserving the meaningful test coverage.Verification
lib/location.jslocally and confirmed the phantomjs trace test passes against the updated fixture.🤖 Generated with Claude Code