-
-
Notifications
You must be signed in to change notification settings - Fork 2
feat(cli): add ultracite --frameworks support for create and init #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f6276b4
feat(cli): pass ultracite --frameworks through init command plumbing
PunGrumpy 8851f91
feat(cli): add --frameworks flag to create and init commands
PunGrumpy 03189dc
test(cli): cover ultracite --frameworks parsing and init wiring
PunGrumpy 6c0dbf3
docs(cli): document ultracite --frameworks flag
PunGrumpy 550d784
chore: add changeset for ultracite frameworks support
PunGrumpy e04ab9b
refactor(cli): simplify ultracite framework defaults after deslop
PunGrumpy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@vernostudio/cli": patch | ||
| --- | ||
|
|
||
| Add `--frameworks` support for Ultracite init: interactive multiselect in create/init wizards, `react next` defaults in `-y` mode, and manifest persistence for selected preset extends | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| import { describe, expect, test } from "bun:test"; | ||
| import { parseUltraciteFrameworksArg } from "../src/ultracite-framework"; | ||
| import { parseUltraciteFrameworksFlag } from "../src/commands/shared/ultracite"; | ||
|
|
||
| describe("parseUltraciteFrameworksArg", () => { | ||
| test("parses comma-separated frameworks and dedupes", () => { | ||
| expect(parseUltraciteFrameworksArg("react,next,react")).toEqual(["react", "next"]); | ||
| }); | ||
|
|
||
| test("parses space-separated frameworks", () => { | ||
| expect(parseUltraciteFrameworksArg("react next")).toEqual(["react", "next"]); | ||
| }); | ||
|
|
||
| test("rejects unknown framework ids", () => { | ||
| expect(() => parseUltraciteFrameworksArg("react,unknown")).toThrow( | ||
| 'Invalid framework "unknown"', | ||
| ); | ||
| }); | ||
| }); | ||
|
|
||
| describe("parseUltraciteFrameworksFlag", () => { | ||
| test("returns undefined when ultracite is off and flag omitted", () => { | ||
| expect(parseUltraciteFrameworksFlag({}, false)).toBeUndefined(); | ||
| }); | ||
|
|
||
| test("throws when flag is set without ultracite add-on", () => { | ||
| expect(() => parseUltraciteFrameworksFlag({ frameworks: "react" }, false)).toThrow( | ||
| "--frameworks requires ultracite", | ||
| ); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.