Merged
Conversation
# Details - HomeBrew no longer exposes `clang-format@21`. Now it's `clang-format@22`. - In CI we only run worker `lint` in macOS so we are good. - Problem is that our `Dockerfile` files install `clang-format-21` which won't be valid anymore. We will fix it in April when Ubuntu 26 is out which in theory comes with `clang-format-22` package (not 100% sure but anyway).
jmillan
approved these changes
Mar 13, 2026
Member
|
Regarding to linux the new version can be installed via brew https://formulae.brew.sh/formula/clang-format. |
Member
Author
If you want to investigate, I cannot have it working. Modified FROM ubuntu:25.10
# Install dependencies.
RUN set -x \
&& apt-get update \
&& apt-get install --yes \
clang-21 make pkg-config bash-completion wget curl screen python3-pip python3-yaml \
zlib1g-dev libgss-dev libssl-dev libxml2-dev gdb procps file git clang-tidy-21
# Install HomeBrew.
#
# Here we create a fake /.dockerenv file to make the HomeBrew install script allow
# installation with root user.
RUN touch /.dockerenv
RUN bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)"
# Install clang-format v22.
RUN brew install clang-format@22
# Install node 24.
RUN curl -fsSL https://deb.nodesource.com/setup_24.x | bash - \
&& apt-get install --yes nodejs
# Enable core dumps.
RUN set -x \
&& echo "mkdir -p /tmp/cores && chmod 777 /tmp/cores && echo \"/tmp/cores/core.%e.sig%s.%p\" > /proc/sys/kernel/core_pattern && ulimit -c unlimited" >> ~/.bashrc
# Make CC and CXX point to clang/clang++ installed above.
ENV LANG="C.UTF-8"
ENV CC="clang-21"
ENV CXX="clang++-21"
ENV MEDIASOUP_LOCAL_DEV="true"
ENV KEEP_BUILD_ARTIFACTS="1"
WORKDIR "/foo bar/mediasoup"
CMD ["bash"]Then |
Member
Author
|
Wait. |
It's probably a beta but it comes with clang-format-22
jmillan
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
clang-format@21. Now it'sclang-format@22.lintin macOS so we are good.worker/Dockerfile: use ubuntu 26.04. It's probably a beta version but it comes withclang-format-22apt package.Bonus tracks
test-werift-sctp.ts. Something related towerift-sctplibrary that honestly I don't care much about.Logger.ts: Importlog(),warn()anderror()fromnode:consoleso we can add aLogger(if needed eventually) in Node test files and Jest won't make them print ugly output (this is because Jest overridesconsoleglobal object. Now it cannot do it.