Skip to content

Fix typos in comments#951

Open
mvgijssel wants to merge 1 commit intomainfrom
claude/fix-typo-osOMC
Open

Fix typos in comments#951
mvgijssel wants to merge 1 commit intomainfrom
claude/fix-typo-osOMC

Conversation

@mvgijssel
Copy link
Copy Markdown
Member

Summary

  • Fix "persistant" → "persistent" in libs/pikvm-lxc/pikvm.yaml.pkrtpl.hcl
  • Fix "overriden" → "overridden" in libs/rules_release/release/private/utils.bzl

Test plan

  • Changes are comment-only, no functional impact

https://claude.ai/code/session_012yY6Ze8nERmJsNAez4qNLW

@github-actions
Copy link
Copy Markdown

Run report for 4f5375d4 (ubuntu-latest, Linux, 0, 2, 1)

Total time: 2m 50s | Comparison time: 23m 1s | Estimated savings: 20m 11s (87.7% faster)

Action Time Status Info
🟩 SyncWorkspace 9.2ms Passed
🟩 SyncProject(devcontainer) 0.6ms Passed
🟦 RunTask(talos-image:generate-sha) 1.8s Cached
🟩 RunTask(docker:buildx_run) 1.8s Passed
🟦 RunTask(devcontainers-cli:build) 6.9s Cached
🟦 RunTask(vendir:build) 2m 26s Cached SLOW
🟦 RunTask(vendir:test) 398.3ms Cached
🟦 RunTask(talos-image:generate-profile) 1.2s Cached
🟦 RunTask(devcontainer:build) 2s Cached
🟦 RunTask(devcontainer:test) 1.1s Cached
🟩 RunTask(devenv:apply) 23.4s Passed
Environment

OS: Linux
Matrix:

os = ubuntu-latest
name = Linux
index = 0
total = 2
job_number = 1

Variables:

MOON_TOOLCHAIN_FORCE_GLOBALS = true
Touched files
libs/pikvm-lxc/pikvm.yaml.pkrtpl.hcl
libs/rules_release/release/private/utils.bzl

@github-actions
Copy link
Copy Markdown

Run report for 4f5375d4 (ubuntu-latest, Linux, 1, 2, 2)

Total time: 2m 28s | Comparison time: 19m 8s | Estimated savings: 16m 40s (87.1% faster)

Action Time Status Info
🟩 SyncWorkspace 8.8ms Passed
🟩 SyncProject(escaperoom) 0.4ms Passed
🟦 RunTask(talos-image:generate-sha) 1.3s Cached
🟩 SyncProject(devcontainer) 0.5ms Passed
🟩 RunTask(docker:buildx_run) 1.5s Passed
🟦 RunTask(escaperoom:test) 1.3s Cached
🟦 RunTask(devcontainers-cli:build) 4s Cached
🟦 RunTask(vendir:build) 2m 2s Cached SLOW
🟦 RunTask(vendir:test) 394.4ms Cached
🟦 RunTask(talos-image:generate-profile) 1.2s Cached
🟦 RunTask(devcontainer:build) 1.9s Cached
🟩 RunTask(devenv:apply) 25.8s Passed
Environment

OS: Linux
Matrix:

os = ubuntu-latest
name = Linux
index = 1
total = 2
job_number = 2

Variables:

MOON_TOOLCHAIN_FORCE_GLOBALS = true
Touched files
libs/pikvm-lxc/pikvm.yaml.pkrtpl.hcl
libs/rules_release/release/private/utils.bzl

@github-actions
Copy link
Copy Markdown

Run report for 4f5375d4 (macos-latest, macOS, 0, 1, 1)

Total time: 8m 23s | Comparison time: 19m 1s | Estimated savings: 10m 37s (55.9% faster)

Action Time Status Info
🟩 SyncWorkspace 16.1ms Passed
🟩 SyncProject(vendir) 1.1ms Passed
🟩 SyncProject(devenv) 0.8ms Passed
🟦 RunTask(vendir:build) 1m 32s Cached
🟩 RunTask(devenv:apply) 6m 50s Passed SLOW
🟦 RunTask(devenv:test) 749.1ms Cached
Environment

OS: macOS
Matrix:

os = macos-latest
name = macOS
index = 0
total = 1
job_number = 1

Variables:

MOON_TOOLCHAIN_FORCE_GLOBALS = true
Touched files
libs/pikvm-lxc/pikvm.yaml.pkrtpl.hcl
libs/rules_release/release/private/utils.bzl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants