Skip to content

remove vg paths -V#4846

Open
faithokamoto wants to merge 3 commits intomasterfrom
deprecate-extract-vg
Open

remove vg paths -V#4846
faithokamoto wants to merge 3 commits intomasterfrom
deprecate-extract-vg

Conversation

@faithokamoto
Copy link
Contributor

@faithokamoto faithokamoto commented Mar 6, 2026

Changelog Entry

To be copied to the draft changelog by merger:

  • Remove broken vg paths --extract-vg option

Description

This doesn't work; the .vg it outputs is malformed and can't be used elsewhere, or at least that happened for my script. So we should just not even offer the option.

Copy link
Member

@adamnovak adamnovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we do want to remove this. I don't think this PR "deprecates" it though; it just removes it.

(It works as designed, it just does a weird thing (generate a fragment of a Protobuf .vg file that indeed can't be independently loaded) which nobody actually wants to do and which is easy to mistake for something more useful.)

@faithokamoto faithokamoto changed the title deprecate vg paths -V remove vg paths -V Mar 6, 2026
@faithokamoto
Copy link
Contributor Author

Some toil tests failed. Not sure how to run those outside so I tossed a best-guess fix in. If that fails I'll figure out something more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants