Stop flipping nodes in vg paths -u#4848
Merged
glennhickey merged 2 commits intomasterfrom Mar 11, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
Description
I forgot that the path cover implementation would flip nodes around (in order to make sure that covering intervals are uniformly forwards strand -- a (reasonable) rgfa requirement).
But that's counterintuitive to how I imagine using it -- if I make a cover for an existing hprc graph I definitely do not want to quietly alter its topology.
So this PR changes things so that it finds the best cover it can on the graph its given. Any node-flipping will have to be done upstream if desired.