Open
Conversation
…e documented name
…d give kmc a useful file limit
Member
Author
|
I don't think the "weak" alias approach would work unless the haplotype-sampled GBZ knew it was always sample-scoped and always had |
Member
Author
|
I haven't done weak aliases, but I've made the scopes keyed (so we know we're dealing with a scope for "sample"), and I've introduced Snakemake-style |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
vg giraffe --haplotype-samplingto automatically count kmers and haplotype-index and haplotype-sample the graph. Make sure to have kmc installed. Providing either a--kff-nameor--haplotype-namewill now also trigger generation of the other. To do one-reference sampling, continue to use--set-reference. To do non-diploid sampling with a certain number of haplotypes, use--no-diploid-samplingand--num-haplotypes.Description
This allows Giraffe to be used as a single-command haplotype sampling workflow, without needing separate commands to count kmers, haplotype-index the graph, haplotype-sample the graph, and map.
I introduced a notion of "scopes" for indexes in the registry, so I could attach a scope of the sample name to the FASTQ or KFF and have it propagate and qualify/subscript all indexes that depend on them. This works OK, but to get the "right" filenames we'd been using for the sampled GBZ (
<prefix>.<sample>.gbz), when it's doubling as a "Giraffe GBZ", I've had to introduce a notion of multiple possible extensions for an index, and then a bunch of logic to work out which of the extensions we actually should use so we don't conflict with older things in the plan.I think I might be able to replace all that with a notion of "weak" aliases, so the "Giraffe GBZ" can come from the "Haplotype-Sampled GBZ" but use it at the "Haplotype-Sampled GBZ"'s name instead of its own.