add script to buid fc, fccd and knative by shyamjesal · Pull Request #178 · vhive-serverless/vHive

shyamjesal · 2021-03-17T13:11:41Z

Signed-off-by: Shyam Jesal s.jesalpura@gmail.com

ustiugov · 2021-03-17T14:02:15Z

let's not rush this all in a single PR.

Let me submit a PR with a new firecracker binary first, then let's have another one for the firecracker-containerd binaries, then push the latest knative containers to dockerhub. Then we can package it all in one build script.

Also, from my experience, the script should only build all the binaries and push them on success but do not try to rebase the branches automatically. This must still remain manual (due to complexity and conflicts).

ustiugov

in the scripts, there should be a variable for the branch name. All dependencies should have branches with the same name. It is likely that vHive updates will be mostly driven by changes in the firecracker repo so let's call the branches v<FC_version>_user_page_faults.

I guess that the knative part is incomplete as of now, isn't it?

ustiugov · 2021-03-18T11:01:40Z

scripts/github_runner/setup_runner_host.sh

-
-sudo apt-get update
-sudo apt-get install --yes docker-ce docker-ce-cli containerd.io >> /dev/null
+    jq >> /dev/null


28-29 should be one line

not pushed?

ustiugov · 2021-03-18T11:03:01Z

scripts/rebuild_deps.sh

+# cp build/cargo_target/x86_64-unknown-linux-musl/release/jailer $PWD/../bin/
+
+# install knative dependencies
+sudo apt install -y git


you used git above

scripts/rebuild_deps.sh

ustiugov · 2021-03-18T11:05:05Z

scripts/rebuild_deps.sh

+cd firecracker-containerd
+make all
+
+# copy binaries binaries to vhive/bin


Suggested change

# copy binaries binaries to vhive/bin

# copy binaries to vhive/bin

ustiugov · 2021-03-18T11:05:57Z

scripts/rebuild_deps.sh

+
+cd _submodules/firecracker/
+tools/devtool build --release
+
+# copy binaries binaries to vhive/bin


Suggested change

cd _submodules/firecracker/

tools/devtool build --release

# copy binaries binaries to vhive/bin

ustiugov · 2021-03-18T11:08:21Z

scripts/rebuild_deps.sh

+go get github.com/gogo/protobuf/protoc-gen-gogofaster
+
+#build knative
+git clone -b qp_guest_info https://github.com/ease-lab/serving


make the branch name a variable, also make sure that you don't change qp_quest_info

Signed-off-by: Shyam Jesal <s.jesalpura@gmail.com>

ustiugov

Please add building Docker images of the runners as well (with pushing them to dockerhub).

DOCKER_BUILDKIT=1 docker build -t vhiveease/vhive_dev_env --file ./scripts/github_runner/Dockerfile.cri_dev_env . 
docker push vhiveease/vhive_dev_env
DOCKER_BUILDKIT=1 docker build -t vhiveease/cri_test_runner --file ./scripts/github_runner/Dockerfile.github_runner_cri .
docker push docker.io/vhiveease/cri_test_runner

ustiugov · 2021-03-22T13:25:54Z

scripts/rebuild_deps.sh

+KNATIVE_BRANCH=$2
+
+set -x
+PWD="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"


please replace PWD with MYSCRIPT_DIR or so

ustiugov · 2021-03-22T13:26:48Z

scripts/github_runner/setup_runner_host.sh

-
-sudo apt-get update
-sudo apt-get install --yes docker-ce docker-ce-cli containerd.io >> /dev/null
+    jq >> /dev/null


not pushed?

parent 6674807 author HermioneKT <hermionegrangerkt@gmail.com> 1706694164 +0800 committer HermioneKT <hermionegrangerkt@gmail.com> 1706694164 +0800 test # This is the commit message #157: test # This is the commit message #159: test # This is the commit message #160: test # This is the commit message #161: test # This is the commit message #162: test # This is the commit message #163: test # This is the commit message #164: tesT # This is the commit message #165: test # This is the commit message #166: test # This is the commit message #167: test # This is the commit message #168: test # This is the commit message #169: test # This is the commit message #170: test # This is the commit message #171: Test # This is the commit message #172: test # This is the commit message #173: test # This is the commit message #174: test # This is the commit message #175: test # This is the commit message #176: test # This is the commit message #177: test # This is the commit message #178: test # This is the commit message #179: test # This is the commit message #180: test # This is the commit message #181: test # This is the commit message #182: test # This is the commit message #183: test # This is the commit message #184: test # This is the commit message #185: test # This is the commit message #186: test # This is the commit message #187: test # This is the commit message #188: test # This is the commit message #189: test # This is the commit message #190: Test # This is the commit message #191: Test # This is the commit message #192: test # This is the commit message #193: Test # This is the commit message #194: test # This is the commit message #195: test # This is the commit message #196: test # This is the commit message #197: test # This is the commit message #198: test # This is the commit message #199: Test # This is the commit message #200: test # This is the commit message #201: test # This is the commit message #202: Test # This is the commit message #203: test # This is the commit message #204: test # This is the commit message #205: test # This is the commit message #206: test # This is the commit message #207: test # This is the commit message #208: test # This is the commit message #209: test # This is the commit message #210: test # This is the commit message #211: Test # This is the commit message #212: test # This is the commit message #213: Test # This is the commit message #214: Test # This is the commit message #215: Test # This is the commit message #216: test # This is the commit message #217: Test # This is the commit message #218: test # This is the commit message #219: test # This is the commit message #220: test # This is the commit message #221: test # This is the commit message #222: test # This is the commit message #223: test # This is the commit message #224: test # This is the commit message #225: test # This is the commit message #226: test # This is the commit message #227: test # This is the commit message #228: test # This is the commit message #229: Test # This is the commit message #230: test # This is the commit message #231: test # This is the commit message #232: test # This is the commit message #233: test # This is the commit message #234: Test # This is the commit message #235: test # This is the commit message #236: test # This is the commit message #237: test # This is the commit message #238: test # This is the commit message #239: test # This is the commit message #240: test # This is the commit message #241: test # This is the commit message #242: test # This is the commit message #243: test # This is the commit message #244: test # This is the commit message #245: test # This is the commit message #246: test # This is the commit message #247: test # This is the commit message #248: test # This is the commit message #249: test # This is the commit message #250: test # This is the commit message #251: test # This is the commit message #252: test

shyamjesal self-assigned this Mar 17, 2021

shyamjesal linked an issue Mar 17, 2021 that may be closed by this pull request

Add a script that rebuilds the dependencies' binaries #96

Open

shyamjesal force-pushed the update-deps branch 2 times, most recently from 0b1257c to 58406c0 Compare March 18, 2021 10:11

shyamjesal changed the title ~~update fccd and firecracker binaries~~ add script to buid fc, fccd and knative Mar 18, 2021

ustiugov requested changes Mar 18, 2021

View reviewed changes

shyamjesal force-pushed the update-deps branch from 58406c0 to d2b8086 Compare March 20, 2021 18:34

add script to buid fc, fccd and knative

2ba9b90

Signed-off-by: Shyam Jesal <s.jesalpura@gmail.com>

shyamjesal force-pushed the update-deps branch from d2b8086 to 2ba9b90 Compare March 20, 2021 18:35

ustiugov requested changes Mar 22, 2021

View reviewed changes

ustiugov force-pushed the master branch from d5f7931 to acba40d Compare April 15, 2021 12:07

ustiugov marked this pull request as draft June 18, 2021 22:39

	# copy binaries binaries to vhive/bin
	# copy binaries to vhive/bin

Conversation

shyamjesal commented Mar 17, 2021

Uh oh!

ustiugov commented Mar 17, 2021

Uh oh!

ustiugov left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ustiugov left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ustiugov left a comment •

edited

Loading