RSDK-13360: Automated module template updates#558
Open
Conversation
lia-viam
requested review from
allisonschiang
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debugging this action drove me to absolute madness but it seems to be working now. See #556 and #557 for
pushandworkflow_dispatchopened PRs, respectively. Once viamrobotics/rdk#5777 is merged we can remove my fork from the clone RDK stepThis action operates on a
pushtomaintrigger, which only operates on thegit diffsince the last time it was run, and a failsafeworkflow_dispatchtrigger which can be run manually to regenerate all files and open a PR for changes if necessaryI experienced an extremely confusing sequence of failures on the create-pull-request action which seems to have been somehow related to making multiple calls to actions/checkout, which are now manually put in separate directories
Although the diff only shows changes since I began debugging, this PR should be used for any comments/concerns on the workflow file in general