RSDK-8714: Input Controller wrappers#70
Open
gloriacai01 wants to merge 2 commits intoviamrobotics:mainfrom
Open
RSDK-8714: Input Controller wrappers#70gloriacai01 wants to merge 2 commits intoviamrobotics:mainfrom
gloriacai01 wants to merge 2 commits intoviamrobotics:mainfrom
Conversation
stuqdog
reviewed
Sep 19, 2024
Member
stuqdog
left a comment
stuqdog
left a comment
There was a problem hiding this comment.
A couple minor things but generally looks good to me! I confess I don't have any experience with kotlin or java particularly however, so definitely might've missed something.
| plugins { | ||
| id "com.github.hierynomus.license-report" version "0.16.1" | ||
| id "org.jetbrains.kotlin.jvm" version "2.0.0" | ||
|
|
Member
There was a problem hiding this comment.
(minor) probably should get rid of this newline?
| override fun getManager(): ResourceManager { | ||
| return this.manager | ||
| } | ||
| } No newline at end of file |
Member
There was a problem hiding this comment.
(minor) here and in subsequent files, we should add a newline character here for POSIX compliance.
njooma
approved these changes
Dec 3, 2024
Member
|
Putting on ice for now -- need to take a look at removing the kotlin dependency |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-input controller wrapper + associated tests
-added kotlinx coroutines library as a requirement in gradle for channel use in
streamEvents