[RSDK-11704, RSDK-11603] Update Python SDK with new GetImages signature#982
Merged
hexbabe merged 7 commits intoviamrobotics:mainfrom Aug 27, 2025
Merged
Conversation
Contributor
|
Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!
|
e756726 to
dc6b22f
Compare
593d0ae to
2b52c16
Compare
2b52c16 to
e8cd337
Compare
stuqdog
approved these changes
Aug 26, 2025
Member
stuqdog
left a comment
There was a problem hiding this comment.
looks reasonable to me! I'm curious though what manual testing will be necessary here, if any.
Member
Author
So far I've tested with a Python client that depends on a wheel I built from this feature branch code. Verified |
Member
Author
|
verified Python client and server working with these new changes! Upgraded python camera oak module to feature branch wheel and verified filter source names and extra were received and handled properly. |
stuqdog
added a commit
to stuqdog/python-sdk
that referenced
this pull request
Aug 28, 2025
… signature (viamrobotics#982)" This reverts commit 217af75.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the SDK changes of the Consolidate GetImage(s) project
It
Manual Testing
See comments below