Conversation
Add substring "Munk2D"
viblo
left a comment
viblo
left a comment
There was a problem hiding this comment.
Sorry, I missed this PR completely. I left some comments.
There was a problem hiding this comment.
I dont think this is really necessary, if someone wants to make a PR, the formatting is not so important. Please remove.
But it did make me realize that Issues were turned off. I have now enabled them.
| cmake_minimum_required(VERSION 3.10) | ||
|
|
||
| project(chipmunk) | ||
| project(Munk2D) |
There was a problem hiding this comment.
Are you sure this doesnt break something?
This is what AI review said:
CMakeLists.txt:3 — changing project(chipmunk) to project(Munk2D) breaks the subdirectory CMake files, because they still reference ${chipmunk_SOURCE_DIR} in places like src/CMakeLists.txt:2, tests/CMakeLists.txt:9, and demo/CMakeLists.txt:7. After this rename, chipmunk_SOURCE_DIR is no longer defined, so those paths expand incorrectly and out-of-source CMake builds will misconfigure or fail. If the goal is to rebrand the project name, this change needs to be paired with updating those references to ${PROJECT_SOURCE_DIR} or the new ${Munk2D_SOURCE_DIR} variable.
2 participants
Issue will be nice